From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/xlnx/zynqmp-dpsub: Fix dependencies for COMPILE_TEST Date: Sun, 12 Apr 2026 12:56:35 +1000 Message-ID: In-Reply-To: <20260408081430.1712335-1-wenst@chromium.org> References: <20260408081430.1712335-1-wenst@chromium.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/xlnx/zynqmp-dpsub: Fix dependencies for COMPILE_TEST Author: Chen-Yu Tsai Patches: 5 Reviewed: 2026-04-12T12:56:35.386287 --- This is a single-patch series fixing Kconfig dependencies for the ZynqMP DisplayPort subsystem driver to allow proper `COMPILE_TEST` builds. The change is straightforward and correct. The driver's use of the PHY and DMA subsystems goes through generic framework APIs (`` functions, `dmaengine_*` functions) whose compile-time requirements are already satisfied by the existing `select GENERIC_PHY`, `select DMA_ENGINE`, and `depends on DMADEVICES` lines. The specific driver configs (`PHY_XILINX_ZYNQMP`, `XILINX_ZYNQMP_DPDMA`) are only needed at runtime for the actual hardware PHY and DMA engine instances to be present. **Verdict:** Looks good. The approach is correct and conservative. --- Generated by Claude Code Patch Reviewer