From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/dp: Clear accumulated HPD events after link training Date: Sun, 12 Apr 2026 12:53:17 +1000 Message-ID: In-Reply-To: <20260408084509.555045-1-acelan.kao@canonical.com> References: <20260408084509.555045-1-acelan.kao@canonical.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/i915/dp: Clear accumulated HPD events after link training Author: "Chia-Lin Kao (AceLan)" Patches: 1 Reviewed: 2026-04-12T12:53:17.132011 --- This is a single, well-focused patch addressing a real hardware issue: GPU = hard lockups on MST hubs (specifically Dell U2721DE with Realtek MST hub) c= aused by stale HPD events being replayed after link training completes. The fix is minimal and uses an existing API (`intel_hpd_clear_and_unblock()= `) that was designed precisely for this purpose =E2=80=94 it is already use= d in `intel_crt.c:575` for an analogous "discard stale events after detecti= on" scenario. The approach is sound: events accumulated while HPD was block= ed during link training are stale (they reflect pre-retrain link state), an= d processing them after a successful retrain creates a burst of work that r= aces with the modeset pipeline. The scheduled `intel_encoder_link_check_que= ue_work()` call at line 1161 provides a safety net for detecting any legiti= mate link issues post-retrain. **Verdict: Looks good.** One minor observation below. --- Generated by Claude Code Patch Reviewer