From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: fix UAF in dma_buf_put() tracepoint
Date: Sun, 12 Apr 2026 12:25:40 +1000 [thread overview]
Message-ID: <review-overall-20260408123916.2604101-1-andi.shyti@kernel.org> (raw)
In-Reply-To: <20260408123916.2604101-1-andi.shyti@kernel.org>
Overall Series Review
Subject: dma-buf: fix UAF in dma_buf_put() tracepoint
Author: Andi Shyti <andi.shyti@kernel.org>
Patches: 2
Reviewed: 2026-04-12T12:25:40.908159
---
This is a single-patch fix for a clear use-after-free bug in `dma_buf_put()`. The analysis is correct and the fix is straightforward: the `DMA_BUF_TRACE()` macro dereferences `dmabuf` (specifically taking `dmabuf->name_lock`) and was placed **after** `fput(dmabuf->file)`, which on the final reference drop can free the entire `dma_buf` structure. Moving the tracepoint before `fput()` is the right fix.
The patch is well-described with a clear commit message, proper `Fixes:` tag, and `Reported-by:` attribution.
**Verdict: The fix is correct and should be applied.**
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-12 2:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 11:28 Oops: general protection fault in dma_buf_put Krzysztofik, Janusz
2026-04-08 12:39 ` [PATCH] dma-buf: fix UAF in dma_buf_put() tracepoint Andi Shyti
2026-04-08 12:39 ` Andi Shyti
2026-04-12 2:25 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260408123916.2604101-1-andi.shyti@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox