From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: rcar-du: Fix crash when no CMM is available Date: Sun, 12 Apr 2026 12:28:44 +1000 Message-ID: In-Reply-To: <20260408124205.1962448-1-laurent.pinchart+renesas@ideasonboard.com> References: <20260408124205.1962448-1-laurent.pinchart+renesas@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm: rcar-du: Fix crash when no CMM is available Author: Laurent Pinchart Patches: 2 Reviewed: 2026-04-12T12:28:44.829717 --- This is a single-patch fix for a NULL pointer dereference crash in the R-Car DU driver. The bug is straightforward: commit 3bce3fdd1ff2 refactored CMM handling to use a `struct rcar_du_cmm *cmm` pointer (which contains a `dev` field), but the null-checks were written as `rcrtc->cmm->dev` instead of `rcrtc->cmm`. When no CMM is present, `rcrtc->cmm` is NULL (it's only assigned at `rcar_du_crtc.c:1304` when `rcdu->cmms[swindex].dev` is non-NULL), so dereferencing it to access `->dev` crashes. The fix is correct, minimal, and well-targeted. The Fixes tag, Reported-by, and Tested-by are all present. This is a clean bug fix suitable for merging. --- Generated by Claude Code Patch Reviewer