From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/ivpu: Add support for limiting NPU frequency Date: Sun, 12 Apr 2026 12:24:14 +1000 Message-ID: In-Reply-To: <20260408130827.2082946-1-andrzej.kacprowski@linux.intel.com> References: <20260408130827.2082946-1-andrzej.kacprowski@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: accel/ivpu: Add support for limiting NPU frequency Author: Andrzej Kacprowski Patches: 2 Reviewed: 2026-04-12T12:24:14.831269 --- This is a single patch (v2) adding user-configurable NPU frequency limits to the Intel VPU (IVPU) accelerator driver via new sysfs attributes under a `freq/` subdirectory, plus legacy compatibility aliases. The feature is gated behind firmware API 3.34.0 and restricted to 50XX+ generation hardware for the writable attributes. The overall design is reasonable: a `freq/` group exposes hardware frequency info (read-only) and configurable min/max (read-write for 50XX+), with frequency changes sent to firmware via a new JSM message. However, there are several bugs that need to be fixed before this can be merged. **Key issues:** 1. Duplicate function declaration (copy-paste error) 2. Wrong sysfs path in ABI documentation (hw_min_freq vs hw_max_freq) 3. Type inconsistency between declaration (u16) and usage (u8) 4. Missing locking for concurrent sysfs writes 5. MHz-to-ratio conversion function is LNL-specific but used generically 6. Cleanup gap: `sysfs_add_file_to_group` files aren't covered by devm 7. Stale/incorrect comment --- --- Generated by Claude Code Patch Reviewer