From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/sched: Add test suite for concurrent job submissions Date: Sun, 12 Apr 2026 12:16:53 +1000 Message-ID: In-Reply-To: <20260408154947.85204-1-marco.pagani@linux.dev> References: <20260408154947.85204-1-marco.pagani@linux.dev> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/sched: Add test suite for concurrent job submissions Author: Marco Pagani Patches: 7 Reviewed: 2026-04-12T12:16:53.731140 --- This is a single patch (v2) that adds a new KUnit test suite for concurrent= job submissions to the DRM GPU scheduler. The patch is well-structured and= addresses a genuine gap in test coverage =E2=80=94 the existing tests all = submit jobs from a single thread, whereas real GPU workloads involve concur= rent submissions from multiple userspace contexts. The patch introduces two test cases: (1) parallel bulk submission followed = by manual timeline advance, and (2) interleaved submission with automatic d= uration-based completion using a sliding window. Both are parameterized, th= ough each currently has only a single parameter set. The code is generally clean and follows reasonable patterns. It introduces = `KUNIT_DEFINE_ACTION_WRAPPER` and `kunit_add_action_or_reset` for cleanup, = which is a departure from the existing `init`/`exit` pattern used by the ot= her suites in this file, but is arguably better suited for the more complex= resource lifecycle in concurrent tests. There are a few issues worth discu= ssing. --- Generated by Claude Code Patch Reviewer