From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: uapi: Add macro for chipset specific event ID region Date: Sun, 12 Apr 2026 12:13:17 +1000 Message-ID: In-Reply-To: <20260408163608.361826-2-bence.csokas@arm.com> References: <20260408163608.361826-2-bence.csokas@arm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm: uapi: Add macro for chipset specific event ID region Author: Bence Csokas Patches: 1 Reviewed: 2026-04-12T12:13:17.431218 --- This is a single patch that introduces a `DRM_EVENT_VENDOR_SPECIFIC(_v)` ma= cro to codify the existing convention that DRM event types `>=3D 0x80000000= ` are reserved for chipset/driver-specific use. The concept is sound =E2=80= =94 elevating a comment-only contract into a code-enforced convention is go= od practice for UAPI headers. However, the patch has one notable omission: `nouveau_drm.h` defines `DRM_N= OUVEAU_EVENT_NVIF` as `0x80000000` (line 28) but was not converted. This ap= pears to be because in `nouveau_drm.h` the define appears *before* the `#in= clude "drm.h"` (line 30), so the macro wouldn't be available at the point o= f use. This is a valid technical obstacle, but it should be explicitly call= ed out in the commit message. Silently skipping one of the four vendor-spec= ific event definitions without explanation undermines the goal of making th= e conversion comprehensive. The macro values are all numerically correct =E2=80=94 every converted defi= nition produces the same value as before. --- Generated by Claude Code Patch Reviewer