From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: unload extras for Hopper/Blackwell Date: Sun, 12 Apr 2026 11:19:36 +1000 Message-ID: In-Reply-To: <20260409-b4-blackwell-unload-v1-0-0f5a2ff838dd@nvidia.com> References: <20260409-b4-blackwell-unload-v1-0-0f5a2ff838dd@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: gpu: nova-core: unload extras for Hopper/Blackwell Author: Eliot Courtney Patches: 4 Reviewed: 2026-04-12T11:19:36.530215 --- This is a clean, well-structured 3-patch series that adds support for driver unload/reload on Hopper and Blackwell GPUs in the nova-core Rust driver. The series addresses two concrete issues observed during unload/reload cycles: 1. The FSP (Falcon Security Processor) sometimes has an unconsumed message from a prior session, which must be drained before sending a new one. 2. On architectures that don't use SEC2 (Hopper+), the GSP falcon does the unload work itself, so the driver only needs to wait for the falcon to halt rather than running the full FWSEC-SB + booter unloader sequence. The series depends on two prerequisite series (John Hubbard's Blackwell series and Alexandre Courbot's unload series), which introduce the FSP code, the `unload()` function, and Hopper/Blackwell architecture variants. Since neither prerequisite applies cleanly to drm-next, this series also won't apply as-is, but the patches are straightforward enough that integration shouldn't be a problem. **Overall assessment: The series looks correct and well-motivated.** There are a few minor observations below but no blocking issues. --- Generated by Claude Code Patch Reviewer