public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: convert users of of_drm_find_bridge(), part 4
Date: Sun, 12 Apr 2026 11:12:49 +1000	[thread overview]
Message-ID: <review-overall-20260409-drm-bridge-alloc-getput-drm_of_find_bridge-4-v5-0-d7381c07788a@bootlin.com> (raw)
In-Reply-To: <20260409-drm-bridge-alloc-getput-drm_of_find_bridge-4-v5-0-d7381c07788a@bootlin.com>

Overall Series Review

Subject: drm/bridge: convert users of of_drm_find_bridge(), part 4
Author: Luca Ceresoli <luca.ceresoli@bootlin.com>
Patches: 3
Reviewed: 2026-04-12T11:12:49.754762

---

This is a clean, well-structured 2-patch series converting the two Renesas DU encoder drivers (`rz-du` and `rcar-du`) from the deprecated `of_drm_find_bridge()` to `of_drm_find_and_get_bridge()`, as part of the ongoing DRM bridge refcounting work. The series is at v5 and has already collected Reviewed-by tags from four reviewers (Biju Das, Linus Walleij, Laurent Pinchart, Louis Chauvet).

The approach is sound: use `__free(drm_bridge_put)` on the local `bridge` variable for automatic cleanup, take an extra reference via `drm_bridge_get()` in the panel-bridge path to unify the two branches, and use `no_free_ptr()` to suppress cleanup for error pointers. The v5 simplification with `no_free_ptr` is a nice improvement over explicit goto-based cleanup.

Both patches are correct. The refcounting logic is balanced across all paths. No issues found that would block merging.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-04-12  1:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-09 13:23 [PATCH v5 0/2] drm/bridge: convert users of of_drm_find_bridge(), part 4 Luca Ceresoli
2026-04-09 13:23 ` [PATCH v5 1/2] drm: renesas: rz-du: rzg2l_du_encoder: convert to of_drm_find_and_get_bridge() Luca Ceresoli
2026-04-12  1:12   ` Claude review: " Claude Code Review Bot
2026-04-09 13:23 ` [PATCH v5 2/2] drm: rcar-du: encoder: " Luca Ceresoli
2026-04-12  1:12   ` Claude review: " Claude Code Review Bot
2026-04-12  1:12 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260409-drm-bridge-alloc-getput-drm_of_find_bridge-4-v5-0-d7381c07788a@bootlin.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox