Claude review: Rust bindings for gem shmem

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Rust bindings for gem shmem
Author: Lyude Paul <lyude@redhat.com>
Patches: 12
Reviewed: 2026-04-12T12:01:17.613682

---

This is v10 of the Rust bindings for DRM GEM shmem objects, from Lyude Paul. The series adds two C-side helper exports (`__drm_gem_shmem_free_sgt_locked` and `drm_gem_shmem_get_pages_sgt_locked`), then builds Rust abstractions for SGTable and VMap on top of them. The overall design — using `Devres` to revoke SGTable mappings on driver unbind and lifetime-bounded `VMapRef` vs. owned `VMap` — is sound and well-motivated.

However, there is one significant concern around **object destruction ordering**: when a GEM object with a mapped SGTable is freed while the driver is still bound (the normal case for userspace-driven buffer teardown), `drm_gem_shmem_release` frees the sgt and destroys the `dma_resv`, and then the Rust `Object<T>` field drops run, potentially triggering `SGTableMap::drop` which tries to re-lock the destroyed `dma_resv` and operate on the already-NULL `sgt`. This needs clarification or a fix.

The C patches (2/5, 3/5) are straightforward. The Rust patches (4/5, 5/5) are ambitious and mostly well-structured, with good kunit test coverage in patch 5. A few doc/comment typos and a couple of safety-comment inaccuracies should be cleaned up.

---
Generated by Claude Code Patch Reviewer