Claude review: drm/gpusvm, pagemap: Do not assume DRM pagemap owns device pages

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/gpusvm, pagemap: Do not assume DRM pagemap owns device pages
Author: Matthew Brost <matthew.brost@intel.com>
Patches: 4
Reviewed: 2026-04-12T11:53:26.381511

---

This is a single patch that hardens the DRM pagemap/gpusvm code against encountering device pages not owned by DRM pagemap. The motivation is sound: if a device-private page comes from a different subsystem (not DRM pagemap), `drm_pagemap_page_zone_device_data()` returns meaningless data that would be blindly dereferenced. However, the implementation has several issues:

1. Using `WARN_ON_ONCE` for a legitimately expected condition is inappropriate — it should be a quiet check, not a stack trace.
2. The change to `drm_pagemap_page_zone_device_data()` creates an inconsistency with `drm_pagemap_page_to_dpagemap()` which still dereferences the now-nullable return without a NULL check.
3. The patch does not apply cleanly to drm-next because `drm_pagemap_migrate_to_devmem()` was restructured (the dereferences are now inside an `if (mdetails->source_peer_migrates)` block).
4. The `Suggested-by: sashiko.dev` tag is not a valid email address and doesn't conform to the standard kernel format of `Name <email>`.

The defensive NULL checks in the callers (patches 2 and 3 of the diff) are reasonable hardening, but the core change to `drm_pagemap_page_zone_device_data()` needs rework.

---

---
Generated by Claude Code Patch Reviewer