From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: stm_lvds: Do not fail atomic_check on disabled connector Date: Sun, 12 Apr 2026 11:47:57 +1000 Message-ID: In-Reply-To: <20260409024928.344010-1-marex@nabladev.com> References: <20260409024928.344010-1-marex@nabladev.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: stm_lvds: Do not fail atomic_check on disabled connector Author: Marek Vasut Patches: 1 Reviewed: 2026-04-12T11:47:57.467444 --- This is a single-patch fix for the STM32 LVDS bridge driver. The change is small, correct, and well-motivated: when the connector is disabled (i.e., `conn_state->crtc` is NULL), the `atomic_check` callback should return success (0) rather than `-EINVAL`, because a disabled connector is a perfectly valid state. The original code treated a NULL crtc as an error, which caused suspend/resume to fail when `atomic_check` was called on an already-disabled connector. The fix is clean and follows the same pattern used by other DRM drivers (analogix_dp, vmwgfx, vkms). **Verdict: Looks good to apply.** --- Generated by Claude Code Patch Reviewer