From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: Add missing bug fixes Date: Sun, 12 Apr 2026 11:44:33 +1000 Message-ID: In-Reply-To: <20260409062617.1182-1-jianping.li@oss.qualcomm.com> References: <20260409062617.1182-1-jianping.li@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: misc: fastrpc: Add missing bug fixes Author: Jianping Li Patches: 6 Reviewed: 2026-04-12T11:44:33.724906 --- This v4 series addresses memory handling issues in the FastRPC driver's Audio PD remote heap. Patch 1 is a clear, correct bugfix. Patch 2 is a reasonable race-condition fix. Patch 4 is a clean, standard cleanup. However, **Patch 3 has critical bugs** that will cause kernel crashes at module removal time: the `remote_heap` allocated via `kzalloc` in probe has `NULL` `dev` and `fl` fields, so calling `fastrpc_buf_free()` on it dereferences NULL pointers. There are also resource leak issues and use of potentially uninitialized data. The series should not be merged until Patch 3 is reworked. --- --- Generated by Claude Code Patch Reviewer