From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: tdfxfb: avoid divide-by-zero on FBIOPUT_VSCREENINFO Date: Sun, 12 Apr 2026 11:09:30 +1000 Message-ID: In-Reply-To: <2026040913-despite-entering-a017@gregkh> References: <2026040913-despite-entering-a017@gregkh> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: fbdev: tdfxfb: avoid divide-by-zero on FBIOPUT_VSCREENINFO Author: Greg Kroah-Hartman Patches: 2 Reviewed: 2026-04-12T11:09:30.726142 --- This is a single patch from Greg Kroah-Hartman that adds a divide-by-zero g= uard for `pixclock` in the `tdfxfb` driver's `tdfxfb_check_var()` function.= The fix itself is correct and straightforward =E2=80=94 `PICOS2KHZ(a)` is = defined as `1000000000UL/(a)` (in `include/uapi/linux/fb.h:240`), so passin= g `pixclock =3D=3D 0` would cause a division by zero. The patch places the = check at the right location (before the first use of `PICOS2KHZ(var->pixclo= ck)` at line 499). There is one notable issue with the commit message. --- Generated by Claude Code Patch Reviewer