From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/ttm/tests: Remove checks from ttm_pool_free_no_dma_alloc Date: Sun, 12 Apr 2026 11:03:53 +1000 Message-ID: In-Reply-To: <20260409142658.1511941-2-dev@lankhorst.se> References: <20260409142658.1511941-2-dev@lankhorst.se> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/ttm/tests: Remove checks from ttm_pool_free_no_dma_alloc Author: Maarten Lankhorst Patches: 1 Reviewed: 2026-04-12T11:03:53.106940 --- This is a single-patch fix that removes broken assertions from the `ttm_poo= l_free_no_dma_alloc` kunit test. The fix is correct and appropriate as a CI= -unblocking measure. The root cause is well-identified: without `TTM_ALLOCA= TION_POOL_USE_DMA_ALLOC`, `ttm_pool_select_type()` does not return the pool= 's own `pool->caching[caching].orders[order]` entry =E2=80=94 on x86 it ret= urns a global pool, and on !x86 it returns NULL. In both cases, the per-poo= l `ttm_pool_type` is never initialized via `ttm_pool_type_init()`, so calli= ng `list_lru_count()` on it is invalid. The patch is a reasonable quick fix to unbreak CI. The test still exercises= the alloc/free path itself, but it no longer verifies any postconditions. **Recommendation: Accept**, with minor nits below. --- Generated by Claude Code Patch Reviewer