From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/amdxdna: Expose per-client BO memory usage via fdinfo Date: Sun, 12 Apr 2026 11:06:37 +1000 Message-ID: In-Reply-To: <20260409152259.176883-1-lizhi.hou@amd.com> References: <20260409152259.176883-1-lizhi.hou@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: accel/amdxdna: Expose per-client BO memory usage via fdinfo Author: Lizhi Hou Patches: 3 Reviewed: 2026-04-12T11:06:37.322159 --- This is a single patch adding per-client BO memory usage reporting via the = fdinfo interface to the amdxdna accel driver. The approach is sound and fol= lows established patterns used by other drivers (e.g., panthor). The patch = hooks `drm_show_fdinfo` into file_operations and provides a custom `show_fd= info` callback in `drm_driver` that reports driver-specific memory categori= es before calling `drm_show_memory_stats()` for the standard DRM memory sta= ts. The implementation is straightforward and mostly correct. There are a few i= ssues worth addressing =E2=80=94 one potential unsigned underflow, a type w= idth concern, and minor style/doc nits. --- --- Generated by Claude Code Patch Reviewer