From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/gem: Fix inconsistent plane dimension calculation in drm_gem_fb_init_with_funcs()
Date: Sun, 12 Apr 2026 10:54:06 +1000 [thread overview]
Message-ID: <review-overall-20260409164156.2235189-1-ashutoshdesai993@gmail.com> (raw)
In-Reply-To: <20260409164156.2235189-1-ashutoshdesai993@gmail.com>
Overall Series Review
Subject: drm/gem: Fix inconsistent plane dimension calculation in drm_gem_fb_init_with_funcs()
Author: Ashutosh Desai <ashutoshdesai993@gmail.com>
Patches: 4
Reviewed: 2026-04-12T10:54:06.081036
---
This is a single-patch fix for a real inconsistency between `framebuffer_check()` in `drm_framebuffer.c` and `drm_gem_fb_init_with_funcs()` in `drm_gem_framebuffer_helper.c`. The analysis in the commit message is correct: the open-coded truncating division can produce `height=0` for chroma planes when the framebuffer height is not evenly divisible by `vsub` (and likewise for width/hsub). The `(height - 1)` expression at line 186 then wraps as an unsigned integer, corrupting the `min_size` check.
The fix is straightforward, correct, and aligns the GEM size validation with the dimension calculation already used by `framebuffer_check()`. **The patch should be accepted**, but it has process issues that should be addressed before merging.
**Verdict: Needs minor revision (process tags), code change itself is correct.**
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-12 0:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 16:41 [PATCH] drm/gem: Fix inconsistent plane dimension calculation in drm_gem_fb_init_with_funcs() Ashutosh Desai
2026-04-10 8:26 ` Jani Nikula
2026-04-10 22:06 ` ashutosh desai
2026-04-10 22:10 ` Ashutosh Desai
2026-04-12 0:54 ` Claude review: " Claude Code Review Bot
2026-04-12 0:54 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260409164156.2235189-1-ashutoshdesai993@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox