From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/dp/mst: fix OOB reads on 2-byte fields in sideband reply parsers
Date: Sun, 12 Apr 2026 10:31:51 +1000 [thread overview]
Message-ID: <review-overall-20260410040026.2436280-1-ashutoshdesai993@gmail.com> (raw)
In-Reply-To: <20260410040026.2436280-1-ashutoshdesai993@gmail.com>
Overall Series Review
Subject: drm/dp/mst: fix OOB reads on 2-byte fields in sideband reply parsers
Author: Ashutosh Desai <ashutoshdesai993@gmail.com>
Patches: 1
Reviewed: 2026-04-12T10:31:51.646390
---
This is a single-patch series that fixes out-of-bounds reads in three DP MST sideband reply parsers. The bug is real: 16-bit field reads access `raw->msg[idx]` and `raw->msg[idx+1]` but only validate bounds *after* incrementing `idx`, meaning the second byte can read past valid message data when `idx == raw->curlen - 1`, or both bytes when `idx == raw->curlen`.
The fix is **correct in approach** — it moves bounds checks before the 2-byte reads using `idx + 2 > raw->curlen`, which is the right pattern. However, there are several issues worth addressing before the patch is merged: missing `Fixes:` and `Cc: stable` tags, some redundant checks introduced by the patch, and a slightly misleading commit message.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 0:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 4:00 [PATCH] drm/dp/mst: fix OOB reads on 2-byte fields in sideband reply parsers Ashutosh Desai
2026-04-12 0:31 ` Claude Code Review Bot [this message]
2026-04-12 0:31 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260410040026.2436280-1-ashutoshdesai993@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox