Claude review: drm/dp/mst: fix buffer overflows in sideband chunk accumulation

Claude Code Review Bot
2026-04-12T00:28:55Z

Overall Series Review

Subject: drm/dp/mst: fix buffer overflows in sideband chunk accumulation
Author: Ashutosh Desai <ashutoshdesai993@gmail.com>
Patches: 1
Reviewed: 2026-04-12T10:28:55.630601

---

This is a single-patch series adding bounds checks to `drm_dp_sideband_append_payload()` in the DP MST sideband message handling code. The patch addresses real overflow risks — particularly the `chunk[48]` overflow when `msg_len` (a 6-bit field, max 63) exceeds the buffer size, and the `msg[256]` accumulation overflow. The code changes are correct and the checks are properly placed with correct arithmetic (C integer promotion ensures u8 values are compared as `int`, avoiding wraparound in the comparisons).

However, the commit message overstates the severity by describing three "bugs" when one of them (bug #1, the zero-length `msg_len` case) is already prevented by an existing check in `drm_dp_decode_sideband_msg_hdr()`. This is worth flagging because it may indicate the author didn't fully trace the call chain before writing the description.

**Verdict:** The actual code fix is sound and addresses genuine vulnerabilities, but the commit message needs correction. Likely worth a request for a v2 with an accurate description.

---

---
Generated by Claude Code Patch Reviewer