From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/qaic: fix incorrect counter check in RAS message decode Date: Sun, 12 Apr 2026 09:40:28 +1000 Message-ID: In-Reply-To: <20260410112015.592546-1-alok.a.tiwari@oracle.com> References: <20260410112015.592546-1-alok.a.tiwari@oracle.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: accel/qaic: fix incorrect counter check in RAS message decode Author: Alok Tiwari Patches: 3 Reviewed: 2026-04-12T09:40:28.470501 --- This is a single-patch fix for a clear copy-paste bug in the QAIC accelerat= or RAS (Reliability, Accessibility, Serviceability) error counter logic. Th= e fix is correct, minimal, and obviously right. The bug was introduced in c= ommit c11a50b170e7 and causes `ue_count` and `ue_nf_count` to be gated by t= he wrong overflow check =E2=80=94 they look at `ce_count` instead of their = own counter. This means those counters stop incrementing once `ce_count` (n= ot the relevant counter) saturates at `UINT_MAX`, which is both functionall= y wrong and could mask uncorrectable error reporting. **Verdict: This patch should be accepted.** --- Generated by Claude Code Patch Reviewer