From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: remove drm bridge in error paths Date: Sun, 12 Apr 2026 09:18:43 +1000 Message-ID: In-Reply-To: <20260410212746.413492-1-osama.abdelkader@gmail.com> References: <20260410212746.413492-1-osama.abdelkader@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm: remove drm bridge in error paths Author: Osama Abdelkader Patches: 1 Reviewed: 2026-04-12T09:18:43.745973 --- This is a 3-patch series fixing resource leaks where `drm_bridge_add()` is called during probe but `drm_bridge_remove()` is not called when a subsequent operation in the probe path fails. All three bugs are real and follow the same pattern: bridge is added, then a later step fails, and the error path doesn't undo the bridge registration. The fixes are small, targeted, and appropriate. The diffstat (`+11/-2`) is consistent with straightforward error-path fixups. **One suggestion for the whole series**: all three drivers use `drm_bridge_add()` manually, but `devm_drm_bridge_add()` (available at `drm_bridge.h:1321`) exists and would handle cleanup automatically on device removal. Converting to `devm_drm_bridge_add()` would eliminate both the error-path bugs *and* the manual `drm_bridge_remove()` calls in each driver's `_remove()` function. That said, that would be a separate cleanup patch and is beyond the stated scope of this series. **Note**: The mbox file only contained the cover letter (patch 0/3); the individual patches (1/3, 2/3, 3/3) were not included. The review below is based on analysis of the source files and the described fixes. --- Generated by Claude Code Patch Reviewer