From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/adreno: fix userspace-triggered crash on a2xx-a4xx Date: Sun, 12 Apr 2026 08:59:45 +1000 Message-ID: In-Reply-To: <20260411-adreno-fix-ubwc-v3-1-4983156f3f80@oss.qualcomm.com> References: <20260411-adreno-fix-ubwc-v3-1-4983156f3f80@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/msm/adreno: fix userspace-triggered crash on a2xx-a4xx Author: Dmitry Baryshkov Patches: 2 Reviewed: 2026-04-12T08:59:45.879716 --- This is a single patch (v3) fixing a **userspace-triggerable NULL pointer d= ereference** on Adreno a2xx through a4xx GPUs. The bug was introduced by co= mmit `a452510aad53` which refactored UBWC configuration into a common struc= t and added a pointer (`ubwc_config`) that gets dereferenced in `adreno_get= _param()` =E2=80=94 but a2xx, a3xx, and a4xx GPUs never set this pointer si= nce they predate UBWC support. The fix is correct, minimal, and well-targeted. The approach of returning `= -ENOENT` via the `UERR()` macro is consistent with how other unsupported pa= rameter queries are handled in this function and matches the v2/v3 review f= eedback from Rob Clark. **Verdict: Looks good.** --- Generated by Claude Code Patch Reviewer