From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/nouveau: fix nvkm_device leak on aperture removal failure Date: Sun, 12 Apr 2026 09:12:26 +1000 Message-ID: In-Reply-To: <20260411062938.22925-1-devnexen@gmail.com> References: <20260411062938.22925-1-devnexen@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/nouveau: fix nvkm_device leak on aperture removal failure Author: David Carlier Patches: 1 Reviewed: 2026-04-12T09:12:26.635838 --- This is a single-patch series fixing a resource leak in `nouveau_drm_probe()`. The analysis and fix are correct. When `aperture_remove_conflicting_pci_devices()` fails, the code previously returned directly, leaking the `nvkm_device` allocated by `nvkm_device_pci_new()` and the `pci_enable_device()` reference it takes internally. The fix properly routes to the existing `fail_nvkm` error label. The patch is minimal, targeted, and appropriate for stable backport. **Verdict: Looks good.** --- --- Generated by Claude Code Patch Reviewer