From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/a6xx: Restore sysprof_active Date: Sun, 12 Apr 2026 08:58:12 +1000 Message-ID: In-Reply-To: <20260411150312.257937-1-robin.clark@oss.qualcomm.com> References: <20260411150312.257937-1-robin.clark@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/msm/a6xx: Restore sysprof_active Author: Rob Clark Patches: 2 Reviewed: 2026-04-12T08:58:12.216601 --- This is a single-patch fix that restores a `.sysprof_setup` vfunc assignment that was accidentally dropped during a refactoring (commit 491fadb2b818, "drm/msm/adreno: Move adreno_gpu_func to catalogue"). Without this assignment, `a6xx_gmu_sysprof_setup()` is never called when userspace starts/stops performance counter collection, meaning IFPC (Idle Frequency Power Collapse) is not inhibited, causing perfcounter select register values to be lost during collapse. The fix is correct and straightforward. One observation worth raising: `a8xx_gpu_funcs` also uses the same GMU infrastructure but does not have `.sysprof_setup` either, which could be a similar gap (though possibly a pre-existing one rather than a regression from the catalogue move). **Verdict:** The patch looks good. One question for the author regarding a8xx coverage. --- Generated by Claude Code Patch Reviewer