From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: host1x: Fix device reference leak in host1x_device_parse_dt() error path Date: Mon, 13 Apr 2026 19:12:54 +1000 Message-ID: In-Reply-To: <20260412120644.2449624-1-lgs201920130244@gmail.com> References: <20260412120644.2449624-1-lgs201920130244@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: gpu: host1x: Fix device reference leak in host1x_device_parse_dt() error path Author: Guangshuo Li Patches: 1 Reviewed: 2026-04-13T19:12:54.751886 --- This is a single-patch fix for a device reference handling bug in the host1x bus driver. The analysis is correct and the fix is appropriate. After `device_initialize()` sets up the embedded `struct device` (including refcount = 1 and kobject internals), the proper teardown path is `put_device()`, not a raw `kfree()`. The patch is minimal, well-targeted, and the commit message adequately explains the rationale. **Verdict: The patch is correct and should be accepted.** --- --- Generated by Claude Code Patch Reviewer