Claude review: gpu: host1x: Fix device reference leak in device_add() error path

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: gpu: host1x: Fix device reference leak in device_add() error path
Author: Guangshuo Li <lgs201920130244@gmail.com>
Patches: 1
Reviewed: 2026-04-13T19:10:39.741073

---

This is a single-patch fix targeting a device reference leak in the `host1x_device_add()` error path when `device_add()` fails for a device with no subdevices. The identified bug is real: the original code logs the error but falls through to `return 0`, leaking the device reference and leaving a half-initialized device on `host1x->devices`.

However, **the proposed fix introduces a new bug** — a double list removal that will crash or warn on most kernel configurations. The `list_del()` call poisons the list pointers, and then `put_device()` triggers the release callback (`host1x_device_release` → `__host1x_device_del`) which calls `list_del_init()` on those same poisoned pointers. On kernels without `CONFIG_DEBUG_LIST` / `CONFIG_LIST_HARDENED` (i.e., most production kernels), this dereferences `LIST_POISON1`/`LIST_POISON2` and causes a kernel oops.

**Recommendation: Needs revision (NAK as-is).**

---

---
Generated by Claude Code Patch Reviewer