public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Revert "drm: Fix use-after-free on framebuffers and property blobs when calling drm_dev_unplug"
Date: Mon, 13 Apr 2026 18:38:29 +1000	[thread overview]
Message-ID: <review-overall-20260413080333.3079490-1-linux@leemhuis.info> (raw)
In-Reply-To: <20260413080333.3079490-1-linux@leemhuis.info>

Overall Series Review

Subject: Revert "drm: Fix use-after-free on framebuffers and property blobs when calling drm_dev_unplug"
Author: Thorsten Leemhuis <linux@leemhuis.info>
Patches: 2
Reviewed: 2026-04-13T18:38:29.230621

---

This is a pair of stable-kernel backports of the same upstream revert (commit `45ebe43ea00d`), targeting **6.6.y** and **6.1.y** respectively. Both patches revert commit `6bee098b9141` ("drm: Fix use-after-free on framebuffers and property blobs when calling drm_dev_unplug"), which was causing warning backtraces reported by Guenter Roeck.

The revert is well-justified with detailed review from Simona Vetter explaining why the original fix was wrong at the DRM core level (the protection should be in the xe driver, not in core DRM), and it carries appropriate tags: Reported-by, Tested-by, Acked-by from Simona, and a Fixes tag.

Both patches are straightforward mechanical reverts adapted for their respective stable branches. The changes look correct. The upstream revert has already landed on drm-next — the current tree at `drm_file.c:252` and `drm_mode_config.c:591-597` already reflects the reverted state.

**Verdict: Both patches look correct and ready for stable.**

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-13  8:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-28 10:30 Warnings and errors in drm_mode_config_cleanup when booting 6.19.10 and 7.0-rc5 Matt Fagnani
2026-03-28 10:52 ` Thorsten Leemhuis
2026-04-02 12:12   ` Greg KH
2026-04-06  7:54     ` Matt Fagnani
2026-04-06  8:17       ` Greg KH
2026-04-13  7:58         ` Thorsten Leemhuis
2026-04-13  8:03           ` [PATCH 6.6.y] Revert "drm: Fix use-after-free on framebuffers and property blobs when calling drm_dev_unplug" Thorsten Leemhuis
2026-04-13  8:38             ` Claude Code Review Bot [this message]
2026-04-13  8:05           ` [PATCH 6.1.y] " Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260413080333.3079490-1-linux@leemhuis.info \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox