From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: handle IRQ_HPD events correctly Date: Thu, 23 Apr 2026 09:32:08 +1000 Message-ID: In-Reply-To: <20260420-hpd-irq-events-v2-0-402ffe27e9e9@oss.qualcomm.com> References: <20260420-hpd-irq-events-v2-0-402ffe27e9e9@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm: handle IRQ_HPD events correctly Author: Dmitry Baryshkov Patches: 7 Reviewed: 2026-04-23T09:32:08.870531 --- This is a v2 series from Dmitry Baryshkov that plumbs IRQ_HPD (short hotplug pulse / AltMode IRQ) events through the DRM connector and bridge infrastructure, from USB Type-C sources down to DisplayPort sink drivers. The motivation is solid: DP MST events are delivered via IRQ_HPD, and without this plumbing, USB-C connected DP devices with MST can't receive those notifications. The design is reasonable -- introducing a `drm_connector_status_extra` enum to carry side-band information alongside the existing HPD status, then threading it through the relevant APIs. The v2 change from a boolean `irq_hpd` to an enum is a good extensibility choice. However, there is a **compile-breaking bug** in patch 3, and some design concerns worth discussing around the `drm_bridge_connector_handle_hpd` path where IRQ_HPD events unconditionally trigger `drm_kms_helper_connector_hotplug_event()`, which may cause unnecessary full connector re-detection for what should be a lightweight sink IRQ. **Critical issue count: 1 (build break)** **Design concerns: 1-2** --- --- Generated by Claude Code Patch Reviewer