From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Let userspace know about swapped out panthor GEM objects Date: Thu, 23 Apr 2026 09:29:11 +1000 Message-ID: In-Reply-To: <20260420-panthor-bo-reclaim-observability-v1-0-a4d1a36ee84f@collabora.com> References: <20260420-panthor-bo-reclaim-observability-v1-0-a4d1a36ee84f@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Let userspace know about swapped out panthor GEM objects Author: Nicolas Frattaroli Patches: 6 Reviewed: 2026-04-23T09:29:11.567506 --- This is a clean, small, 2-patch series that adds "evicted" (swapped-out) me= mory tracking to the DRM fdinfo infrastructure and wires it up in the panth= or driver. The motivation is sound: without this, userspace cannot distingu= ish between a BO that was never backed by pages and one that was backed but= later evicted to swap. The implementation is straightforward and follows t= he established patterns for `RESIDENT`, `PURGEABLE`, and `ACTIVE` statuses. **Key observations:** 1. The series depends on a not-yet-landed panthor GEM shrinker series (the = patches reference `bo->backing.pages` while the current drm-next tree uses = `bo->base.pages`, and `panthor_gem_evict_locked` doesn't exist yet). This i= s fine as a dependency chain, but should be noted. 2. The `atomic_t reclaimed_count` wrap-around-avoidance logic is clever but= over-engineered for what is effectively a boolean "has ever been evicted" = flag. The counter approach tries to serve dual duty =E2=80=94 providing the= count for potential future use while also acting as a boolean =E2=80=94 an= d the wrap-around handling adds complexity for a scenario that is practical= ly impossible (2^31 evictions of a single BO). 3. The fdinfo integration in patch 1 is clean and follows established patte= rns correctly. The `supported_status` bitmask mechanism means the "evicted"= line only appears in fdinfo output when at least one object has actually b= een evicted, which is the right behavior. **Overall: Series looks good. A few minor issues and design questions below= .** --- --- Generated by Claude Code Patch Reviewer