From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: rust: add basic serial device bus abstractions Date: Thu, 23 Apr 2026 09:21:38 +1000 Message-ID: In-Reply-To: <20260420-rust_serdev-v5-0-57e8ba0519f3@posteo.de> References: <20260420-rust_serdev-v5-0-57e8ba0519f3@posteo.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: rust: add basic serial device bus abstractions Author: Markus Probst Patches: 5 Reviewed: 2026-04-23T09:21:38.011857 --- This is a v5 series adding Rust serdev (serial device bus) abstractions to the kernel, consisting of 4 patches: a preparatory devres change, a C-side struct modification, the main Rust abstraction, and a sample driver. The overall design follows established kernel Rust patterns well. The `Driver` trait, `Adapter` registration mechanism, and `Device` wrapper are consistent with how other bus abstractions (platform, USB, auxiliary) work. The race condition between `devm_serdev_device_open` and probe completion is handled correctly using a `Completion` barrier. The code is generally well-structured and the safety comments are mostly thorough. Key concerns: (1) the `rust_private_data` field in `struct serdev_device` adds overhead to all serdev devices whether or not a Rust driver is in use; (2) the `devres::register` lifetime extension in patch 1 has a subtle safety argument that deserves careful review from the devres maintainers; (3) there are a few documentation typos/broken links that should be fixed. --- Generated by Claude Code Patch Reviewer