From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev/offb: fix PCI device reference leak on probe failure Date: Thu, 23 Apr 2026 10:29:37 +1000 Message-ID: In-Reply-To: <20260420010118.17960-1-dbgh9129@gmail.com> References: <20260420010118.17960-1-dbgh9129@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: fbdev/offb: fix PCI device reference leak on probe failure Author: Yuho Choi Patches: 1 Reviewed: 2026-04-23T10:29:37.182445 --- This is a single-patch series that fixes a PCI device reference leak in the `offb` framebuffer driver. The fix is correct and straightforward: `pci_get_device()` returns a device with an incremented reference count, and the original code failed to call `pci_dev_put()` when `pci_enable_device()` failed. The patch properly splits the combined condition to handle each failure case appropriately. The Fixes tag correctly identifies commit 5bda8f7b5468 which introduced the `pci_enable_device()` call and thus the leaking error path. **Verdict: The patch is correct and should be accepted**, with one observation about a pre-existing issue noted below. --- Generated by Claude Code Patch Reviewer