From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: savage: fix probe-path EDID cleanup leaks Date: Thu, 23 Apr 2026 10:23:48 +1000 Message-ID: In-Reply-To: <20260420051926.28276-1-dbgh9129@gmail.com> References: <20260420051926.28276-1-dbgh9129@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: fbdev: savage: fix probe-path EDID cleanup leaks Author: Yuho Choi Patches: 1 Reviewed: 2026-04-23T10:23:48.511522 --- This is a single-patch series that fixes a real memory leak in the savagefb probe error path. The analysis is correct: when `CONFIG_FB_SAVAGE_I2C` is enabled, `savagefb_probe()` allocates both `info->monspecs.modedb` (via `fb_edid_to_monspecs`) and modelist entries (via `fb_videomode_to_modelist`), but the `failed:` cleanup label only deleted the I2C busses without freeing these allocations. The fix is minimal, correct, and safe against double-free. **Recommend accept**, with one minor observation. --- Generated by Claude Code Patch Reviewer