From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: jdi-fhd-r63452: remove panel on DSI attach failure Date: Thu, 23 Apr 2026 10:13:55 +1000 Message-ID: In-Reply-To: <20260420065305.8781-1-mhun512@gmail.com> References: <20260420065305.8781-1-mhun512@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/panel: jdi-fhd-r63452: remove panel on DSI attach failure Author: Myeonghun Pak Patches: 2 Reviewed: 2026-04-23T10:13:55.634488 --- This is a single, straightforward bugfix patch. The analysis is correct: in= `jdi_fhd_r63452_probe()`, `drm_panel_add()` is called at line 203, and if = `mipi_dsi_attach()` fails at line 205, the function returns without calling= `drm_panel_remove()`, leaving a stale entry in the global panel list. The = `.remove()` callback won't run because probe failed. The fix is minimal and= correct =E2=80=94 adding `drm_panel_remove(&ctx->panel)` in the error path= before returning. **Verdict: The patch looks good and is correct.** One minor observation: there's no `Fixes:` tag in the commit message, which= would typically be expected for a bugfix. The original commit that introdu= ced this driver should be cited. This helps stable-kernel backporting. --- Generated by Claude Code Patch Reviewer