From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: lg-sw43408: remove panel on DSI attach failure
Date: Thu, 23 Apr 2026 10:12:25 +1000 [thread overview]
Message-ID: <review-overall-20260420073945.65849-1-mhun512@gmail.com> (raw)
In-Reply-To: <20260420073945.65849-1-mhun512@gmail.com>
Overall Series Review
Subject: drm/panel: lg-sw43408: remove panel on DSI attach failure
Author: Myeonghun Pak <mhun512@gmail.com>
Patches: 2
Reviewed: 2026-04-23T10:12:25.537212
---
This is a single-patch fix for a real resource leak in the LG SW43408 panel driver. When `mipi_dsi_attach()` fails during probe, `drm_panel_add()` has already been called (inside `sw43408_add()`), but `sw43408_remove()` is never invoked because probe failed. This leaves a stale entry in the global DRM panel list. The fix correctly unwinds by calling `drm_panel_remove()` on the attach failure path.
The analysis is sound: `devm_drm_panel_alloc()` handles `drm_panel_put()` via devres, but `drm_panel_add()`/`drm_panel_remove()` is a separate pairing that is not automatically managed. All other resources acquired in `sw43408_add()` (regulators, GPIO, backlight) use `devm_` allocators and need no explicit cleanup.
**Verdict: The patch is correct and should be accepted.**
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-23 0:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Casey Connolly <casey.connolly@linaro.org>
2026-04-20 7:38 ` [PATCH v1] drm/panel: lg-sw43408: remove panel on DSI attach failure Myeonghun Pak
2026-04-22 19:24 ` Dmitry Baryshkov
2026-04-23 0:12 ` Claude review: " Claude Code Review Bot
2026-04-23 0:12 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260420073945.65849-1-mhun512@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox