From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: DSC max delta bpp support Date: Thu, 23 Apr 2026 10:06:54 +1000 Message-ID: In-Reply-To: <20260420112611.1481530-1-nemesa.garg@intel.com> References: <20260420112611.1481530-1-nemesa.garg@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: DSC max delta bpp support Author: Nemesa Garg Patches: 5 Reviewed: 2026-04-23T10:06:54.839347 --- This 2-patch series adds support for decoding DSC maximum bpp from the delt= a-based DPCD fields (register 0x06E) defined in eDP 1.5 / DP 2.0. The goal = is reasonable =E2=80=94 some sinks only expose max bpp via the delta encodi= ng rather than the absolute DPCD 0x067/0x068 fields. However, the series has a **correctness bug** (reserved 444 delta values pr= oduce garbage output), **naming convention violations** in the shared DRM h= eader, and questionable placement of driver-specific decode constants in th= e common `drm_dp.h`. The series needs a respin. **Key issues:** - Reserved delta values (22=E2=80=9331) for RGB/YCbCr444 are silently passe= d through without decoding, producing wrong max bpp values. - New macro names in `drm_dp.h` break the `DP_DSC_` naming convention used = throughout the file. - Driver-specific decode constants don't belong in the shared DPCD header. --- --- Generated by Claude Code Patch Reviewer