From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu: Replace VKMS vblank timer with common implementation Date: Thu, 23 Apr 2026 09:48:28 +1000 Message-ID: In-Reply-To: <20260420125223.234974-1-tzimmermann@suse.de> References: <20260420125223.234974-1-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/amdgpu: Replace VKMS vblank timer with common implementation Author: Thomas Zimmermann Patches: 2 Reviewed: 2026-04-23T09:48:28.476506 --- This is a single patch from Thomas Zimmermann that replaces amdgpu's custom= VKMS vblank timer implementation with the shared DRM vblank helper infrast= ructure (`DRM_CRTC_VBLANK_TIMER_FUNCS` / `DRM_CRTC_HELPER_VBLANK_FUNCS`). T= he conversion is straightforward and correct. The shared helpers in `drm_vb= lank_helper.c` and `drm_vblank.c` provide equivalent functionality with imp= roved robustness =E2=80=94 particularly around deadlock avoidance in the ca= ncel path and race handling in the timestamp function. The patch is a net d= eletion of ~120 lines, which is a strong positive. The conversion looks functionally correct. The shared implementation handle= s the same cases as the removed code, with several improvements in the deta= ils. There is one minor cleanup opportunity worth noting. **Verdict: Looks good overall. One minor nit about leftover dead fields.** --- --- Generated by Claude Code Patch Reviewer