From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: Fix DYNAMIC_DEBUG_MODULE propagation to subdirectories Date: Thu, 23 Apr 2026 08:49:02 +1000 Message-ID: In-Reply-To: <20260420160425.3919114-1-sean@poorly.run> References: <20260420160425.3919114-1-sean@poorly.run> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm: Fix DYNAMIC_DEBUG_MODULE propagation to subdirectories Author: Sean Paul Patches: 1 Reviewed: 2026-04-23T08:49:02.797692 --- This is a single-patch fix for a kbuild variable naming bug in the DRM subs= ystem Makefile. The original code used `CFLAGS-$(CONFIG_DRM_USE_DYNAMIC_DEB= UG)` which expands to `CFLAGS-y` =E2=80=94 a variable name that kbuild does= not recognize. As a result, `-DDYNAMIC_DEBUG_MODULE` was never actually pa= ssed to the compiler, meaning `DRM_USE_DYNAMIC_DEBUG` was silently broken a= t the build level (on top of being gated by `depends on BROKEN` in Kconfig). The fix is correct and straightforward. The patch replaces the bogus variab= le with proper kbuild variables and adds subdirectory propagation. The prac= tical impact is near-zero today since `DRM_USE_DYNAMIC_DEBUG` depends on `B= ROKEN`, but it's the right fix for when/if someone removes that dependency. **Recommendation:** Looks good. One minor observation below. --- Generated by Claude Code Patch Reviewer