From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu: fix zero-size GDS range init on RDNA4 Date: Thu, 23 Apr 2026 09:16:00 +1000 Message-ID: In-Reply-To: <20260420215717.223372-1-arjan@linux.intel.com> References: <20260420215717.223372-1-arjan@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/amdgpu: fix zero-size GDS range init on RDNA4 Author: arjan@linux.intel.com Patches: 4 Reviewed: 2026-04-23T09:16:00.379222 --- This is a single-patch fix for a real kernel crash (BUG_ON) when loading amdgpu on RDNA4 hardware (RX 9070 XT). The analysis in the commit message is accurate and the fix is correct and minimal. The patch adds a zero-size guard in `amdgpu_ttm_init_on_chip()` to avoid calling `drm_mm_init(mm, 0, 0)`, which triggers `DRM_MM_BUG_ON(start + size <= start)`. The teardown path is safe: `ttm_range_man_fini_nocheck()` checks `if (!man) return 0` (line 224 of `ttm_range_manager.c`), so skipping init for a zero-size resource won't cause a crash on module unload. There are a couple of process/tagging issues to flag. --- Generated by Claude Code Patch Reviewer