From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: vbios: harden various array accesses and refactor Date: Thu, 23 Apr 2026 08:42:23 +1000 Message-ID: In-Reply-To: <20260421-fix-vbios-v3-0-8f648aef7a85@nvidia.com> References: <20260421-fix-vbios-v3-0-8f648aef7a85@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: gpu: nova-core: vbios: harden various array accesses and refactor Author: Eliot Courtney Patches: 12 Reviewed: 2026-04-23T08:42:23.228483 --- This is a well-structured 11-patch series that hardens the nova-core VBIOS parsing code against malformed firmware. The first 5 patches fix real bugs (integer overflows, unchecked array accesses on firmware-derived values), properly tagged with `Fixes:` lines. Patches 6-10 are incremental refactoring that removes the `FwSecBiosBuilder` intermediate struct, simplifying the code substantially (net -50 lines). Patch 11 aligns PCI-AT/FWSEC image selection with nouveau behavior. The series is logically ordered, each patch compiles independently, and the refactoring is well-motivated. The Rust idioms used (`.get()`, `.checked_add()`, `.checked_sub()`, `.and_then()`, `.ok_or()`) are appropriate for hardening firmware-derived data paths. Joel Fernandes has reviewed most patches. I have one substantive concern (unchecked subtraction in patch 9) and a few minor observations. --- Generated by Claude Code Patch Reviewer