From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: handle IRQ_HPD events correctly Date: Thu, 23 Apr 2026 09:07:42 +1000 Message-ID: In-Reply-To: <20260421-hpd-irq-events-v3-0-44d2bf40dfc2@oss.qualcomm.com> References: <20260421-hpd-irq-events-v3-0-44d2bf40dfc2@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm: handle IRQ_HPD events correctly Author: Dmitry Baryshkov Patches: 8 Reviewed: 2026-04-23T09:07:42.466808 --- This is a well-structured 6-patch series from Dmitry Baryshkov that addresses a real gap in the DRM/USB-C DisplayPort AltMode subsystem: the inability to propagate IRQ_HPD (short hotplug pulses / sink attention requests) through the out-of-band hotplug path. This is critical for DP MST support over USB-C, where MST sideband messages are delivered via IRQ_HPD. The approach is sound: 1. Introduce `enum drm_connector_status_extra` to carry additional event information alongside HPD status 2. Thread this new parameter through the connector, bridge, and aux-hpd APIs 3. Provide backward-compatible inline wrappers so existing callers don't need updating 4. Wire up consumers: MSM DP driver, PMIC GLINK altmode, and Huawei Gaokun UCSI The layering is clean -- core API changes first, then bridge plumbing, then driver consumers. The backward-compatible wrappers (`drm_bridge_hpd_notify()`, `drm_aux_hpd_bridge_notify()`) are a pragmatic choice to avoid cross-tree merge complications. **Minor issues found:** One typo in a commit message, one stray cosmetic change, and a question about the `_extra` naming suffix. No correctness bugs identified. --- --- Generated by Claude Code Patch Reviewer