From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Fix checking of iommu_map_sgtable return value Date: Thu, 23 Apr 2026 08:57:23 +1000 Message-ID: In-Reply-To: <20260421-iommu_map_sgtable-return-v1-0-fb484c07d2a1@nvidia.com> References: <20260421-iommu_map_sgtable-return-v1-0-fb484c07d2a1@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Fix checking of iommu_map_sgtable return value Author: Mikko Perttunen Patches: 5 Reviewed: 2026-04-23T08:57:23.407241 --- This is a clean, well-motivated bugfix series from Mikko Perttunen. The core issue is straightforward: `iommu_map_sgtable()` changed its return type from `size_t` (returning 0 on error) to `ssize_t` (returning negative errno on error), but several callers were never updated and still check for `== 0` or `!ret`. All four patches correctly update the callers to use `ssize_t` and check `< 0`. Each patch is independent, properly tagged with `Fixes:`, and minimal in scope. The series looks correct. I have one minor observation on patch 2, but nothing blocking. **Verdict: Looks good. All four patches are correct and should be applied.** --- --- Generated by Claude Code Patch Reviewer