From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: run unload sequence upon unbinding Date: Thu, 23 Apr 2026 08:52:54 +1000 Message-ID: In-Reply-To: <20260421-nova-unload-v2-0-2fe54963af8b@nvidia.com> References: <20260421-nova-unload-v2-0-2fe54963af8b@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: gpu: nova-core: run unload sequence upon unbinding Author: Alexandre Courbot Patches: 14 Reviewed: 2026-04-23T08:52:54.507537 --- This is a well-structured 5-patch series that implements proper GPU teardow= n upon driver unbind for the nova-core driver. The motivation is clear and = important: without this, the GSP remains running after unbind (potentially = accessing reclaimed memory), and the WPR2 region prevents re-probing withou= t a full PCI reset =E2=80=94 which itself can brick Blackwell GPUs due to a= VBIOS bug. The series is logically ordered: utility macro (1), refactor unbind to use = it (2), namespace cleanup (3), GSP shutdown command (4), and full unload se= quence (5). Each patch is reviewable in isolation and incrementally buildab= le. The code follows existing patterns in the codebase well (e.g., FWSEC/bo= oter loading mirrors `boot()`, the command/reply pattern matches existing G= SP commands). Overall this looks good for merging. I have minor observations but no block= ing issues. --- Generated by Claude Code Patch Reviewer