From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/ttm, drm/xe: Avoid reclaim/eviction loops under fragmentation Date: Thu, 23 Apr 2026 09:01:58 +1000 Message-ID: In-Reply-To: <20260421012608.1474950-1-matthew.brost@intel.com> References: <20260421012608.1474950-1-matthew.brost@intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/ttm, drm/xe: Avoid reclaim/eviction loops under fragmentation Author: Matthew Brost Patches: 12 Reviewed: 2026-04-23T09:01:58.435382 --- This is a well-motivated 3-patch series addressing a real and well-document= ed pathological reclaim loop on Xe iGPU systems under memory fragmentation.= The cover letter clearly describes the problem (kswapd =E2=86=92 shrinker = =E2=86=92 eviction =E2=86=92 rebind loop at ~2 FPS) and demonstrates measur= able improvement (~10 FPS, restored buddyinfo). The approach is sound: (1) teach TTM to only do reclaim at the order the dr= iver actually benefits from, (2) tell TTM that Xe cares about order 9 (2MB)= , and (3) add a heuristic in the Xe shrinker to detect fragmentation-driven= kswapd invocations and bail out early. However, Patch 1 has a significant semantic expansion beyond what the commi= t message emphasizes, and Patch 3 has some robustness concerns around the Z= ONE_NORMAL hardcoding. Overall the series is reasonable but warrants discus= sion on these points. --- --- Generated by Claude Code Patch Reviewer