From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: Remove DRIVER_GEM_GPUVA feature flag
Date: Thu, 23 Apr 2026 08:39:45 +1000 [thread overview]
Message-ID: <review-overall-20260421084701.24227-1-laura.nao@collabora.com> (raw)
In-Reply-To: <20260421084701.24227-1-laura.nao@collabora.com>
Overall Series Review
Subject: drm: Remove DRIVER_GEM_GPUVA feature flag
Author: Laura Nao <laura.nao@collabora.com>
Patches: 4
Reviewed: 2026-04-23T08:39:45.525593
---
This is a clean, well-motivated single-patch cleanup that removes the `DRIVER_GEM_GPUVA` feature flag from the DRM subsystem. The commit message accurately describes the situation: the flag only gates an `INIT_LIST_HEAD()` call and a debugfs entry filter, neither of which justify a per-driver opt-in flag. The patch is straightforward and touches all the right files. There is one potential issue worth discussing regarding nouveau.
**Verdict:** Looks good overall with one minor point to verify.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-22 22:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 8:47 [PATCH] drm: Remove DRIVER_GEM_GPUVA feature flag Laura Nao
2026-04-21 13:01 ` Thomas Hellström
2026-04-21 15:32 ` Liviu Dudau
2026-04-21 16:34 ` Rob Clark
2026-04-22 22:39 ` Claude review: " Claude Code Review Bot
2026-04-22 22:39 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260421084701.24227-1-laura.nao@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox