From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/ivpu: Fix swapped register names in pwr_island_drive functions Date: Thu, 23 Apr 2026 08:38:04 +1000 Message-ID: In-Reply-To: <20260421093907.37304-1-karol.wachowski@linux.intel.com> References: <20260421093907.37304-1-karol.wachowski@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: accel/ivpu: Fix swapped register names in pwr_island_drive functio= ns Author: Karol Wachowski Patches: 1 Reviewed: 2026-04-23T08:38:04.112852 --- This is a single-patch fix for the Intel VPU (NPU) accelerator driver (`acc= el/ivpu`). The patch swaps register name definitions that were incorrectly = used in the wrong hardware-generation-specific functions: `pwr_island_drive= _37xx` was using `VPU_40XX_*` register names, and `pwr_island_drive_40xx` w= as using `VPU_37XX_*` register names. As the commit message correctly states, this is a **purely cosmetic fix** = =E2=80=94 both register names resolve to the same offset (`0x00030024u`) an= d both field masks (`MSS_CPU` for 37xx, `CSS_CPU` for 40xx) resolve to `BIT= _MASK(3)`. The generated code is binary-identical before and after this pat= ch. The fix improves code correctness and readability by ensuring each func= tion uses the register definitions matching its hardware generation. **Verdict**: Straightforward and correct. No functional risk. --- Generated by Claude Code Patch Reviewer