From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: ite-it6263: Support power cycle in runtime Date: Thu, 23 Apr 2026 08:33:48 +1000 Message-ID: In-Reply-To: <20260421105334.43411-1-biju.das.jz@bp.renesas.com> References: <20260421105334.43411-1-biju.das.jz@bp.renesas.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: ite-it6263: Support power cycle in runtime Author: Biju Patches: 3 Reviewed: 2026-04-23T08:33:48.760925 --- This is a single patch that moves IT6263 hardware reset and initialization = from `probe` to `atomic_enable`, enabling the chip to be fully reinitialize= d after a suspend/resume power cycle. The approach of leveraging the existi= ng bridge `atomic_{disable,enable}` callbacks instead of adding dedicated P= M ops is reasonable and matches how other bridge drivers handle this. However, the patch has a **significant issue with regmap cache coherency** = after a power cycle, and a **minor error-handling concern** in the atomic_e= nable path. Without addressing the regmap cache, this patch will produce in= correct hardware configuration on resume (the second and subsequent enable = cycles after a power-loss event). **Verdict: Needs revision** =E2=80=94 the regmap cache staleness issue is a= correctness bug that can cause silent misconfigurations after suspend/resu= me, which is the exact scenario this patch aims to fix. --- Generated by Claude Code Patch Reviewer