From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: fbdev: Use client buffers Date: Thu, 23 Apr 2026 08:30:52 +1000 Message-ID: In-Reply-To: <20260421125733.209568-1-tzimmermann@suse.de> References: <20260421125733.209568-1-tzimmermann@suse.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/msm: fbdev: Use client buffers Author: Thomas Zimmermann Patches: 15 Reviewed: 2026-04-23T08:30:52.675389 --- This is a well-structured 6-patch series from Thomas Zimmermann converting = msm's fbdev emulation to use DRM client buffers. The series follows a clean= progression: expose `msm_framebuffer_init()` =E2=86=92 inline the old help= er =E2=86=92 fix up error reporting =E2=86=92 modernize geometry calculatio= n =E2=86=92 switch to client buffers =E2=86=92 re-hide the internal API. Th= e intent is sound and aligns with the broader DRM effort to unify framebuff= er handling for in-kernel clients. However, **patch 5 has a bug in its error handling** that would cause a `vm= ap_count` underflow warning and incorrect cleanup when `msm_gem_get_vaddr()= ` fails. Otherwise the series is clean and the refactoring is well-decompos= ed. --- Generated by Claude Code Patch Reviewer