From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add support for Renesas RZ/G3L LVDS encoder Date: Thu, 23 Apr 2026 08:20:38 +1000 Message-ID: In-Reply-To: <20260421172910.218497-1-biju.das.jz@bp.renesas.com> References: <20260421172910.218497-1-biju.das.jz@bp.renesas.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Add support for Renesas RZ/G3L LVDS encoder Author: Biju Patches: 3 Reviewed: 2026-04-23T08:20:38.217345 --- This is a v2 series adding support for the RZ/G3L LVDS encoder as a DRM bridge driver, plus its DT bindings. The series is structured well: syscon binding addition, then the DT binding schema, then the driver. The driver follows the existing rz-du driver patterns (similar to `rzg2l_mipi_dsi.c`) and uses modern DRM bridge APIs (`devm_drm_bridge_alloc`, `devm_drm_bridge_add`, atomic enable/disable). The overall approach is sound and the v1->v2 changes show good responsiveness to review feedback. There are several issues ranging from minor cleanups to a few concerns worth addressing: unnecessary includes, inconsistent register macro style, a redundant register definition, and a questionable `pm_runtime_get_sync` error handling pattern. Patch 1/3 (syscon binding) was filtered from the mbox (not on dri-devel) and is not reviewed here. --- --- Generated by Claude Code Patch Reviewer