From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Pass down hot-plug CONNECTOR ID to user-space Date: Thu, 23 Apr 2026 07:36:45 +1000 Message-ID: In-Reply-To: <20260422-hot-plug-passup-v8-0-5cfae6ba4119@collabora.com> References: <20260422-hot-plug-passup-v8-0-5cfae6ba4119@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Pass down hot-plug CONNECTOR ID to user-space Author: Nicolas Frattaroli Patches: 4 Reviewed: 2026-04-23T07:36:45.659725 --- This is a well-motivated v8 of a 2-patch series that fixes a real-world pro= blem: userspace (Weston) missing rapid HPD on-off-on transitions because th= e hotplug uevent didn't identify which connector changed. The approach =E2= =80=94 collecting changed connectors into an array, then sending per-connec= tor hotplug events outside the lock =E2=80=94 is sound and addresses the de= adlock concern from earlier versions. The series is clean, small, and the cover letter does a good job explaining= the history and trade-offs. Two concerns worth discussing: (1) a potential= array bounds issue and (2) a behavioral change in `drm_helper_hpd_irq_even= t` return value semantics. **Verdict**: Mostly good, one potential bug to address, otherwise minor obs= ervations. --- --- Generated by Claude Code Patch Reviewer