From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Pass down hot-plug CONNECTOR ID to user-space
Date: Thu, 23 Apr 2026 07:22:52 +1000
Message-ID: <review-overall-20260422-hot-plug-passup-v9-0-aef804255986@collabora.com>
In-Reply-To: <20260422-hot-plug-passup-v9-0-aef804255986@collabora.com>
References: <20260422-hot-plug-passup-v9-0-aef804255986@collabora.com>
X-Mailer: Claude Code Patch Reviewer
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Overall Series Review

Subject: Pass down hot-plug CONNECTOR ID to user-space
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Patches: 3
Reviewed: 2026-04-23T07:22:52.089066

---

This is a well-motivated 2-patch series at v9 that improves DRM hotplug eve=
nt reporting by sending per-connector `CONNECTOR=3D<id>` uevents instead of=
 generic global hotplug events. The cover letter clearly explains the real-=
world problem: compositors like Weston can miss rapid on-off-on HPD transit=
ions because they can't identify which connector changed. The approach is s=
ound =E2=80=94 split the sysfs uevent (which is safe to call with the mutex=
 held) from `drm_client_dev_hotplug()` (which needs to be called without mo=
de_config locks), thus avoiding the deadlock that plagued earlier versions.

The series is clean and simple at 2 patches / net -1 lines changed. The fir=
st patch is a trivial doc fix, and the second implements the actual behavio=
ral change. The code is a simplification over the current baseline which al=
ready had partial per-connector support (the `first_changed_connector` logi=
c in `drm_helper_hpd_irq_event`). I have a few observations but nothing blo=
cking.

---
Generated by Claude Code Patch Reviewer